Fix #3533: Fix parsing of raw types appearing in generic position #3755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting from d8ff147: Legacy-tests seems to always compile files together, but cooking only works for Java files read by ClassfileParser. I don't think it makes sense to change that - if we compile Java files from sources we should demand that raw types are re-written as wildcard types. Since other tests in the same situation will be added in the future, we create a `pos-java-interop-separate` test folder to keep them together.
smarter
force-pushed
the
fix-raw-in-generic
branch
2 times, most recently
from
1eca461 to
34e3750
Compare
odersky
approved these changes
Jan 7, 2018
| if (isEnum) denot.info = ConstantType(Constant(sym)) | ||
| if (isConstructor) normalizeConstructorParams() | ||
| setPrivateWithin(denot, jflags) | ||
| denot.info = translateTempPoly(parseAttributes(sym, denot.info)) | ||
| denot.info = translateTempPoly(cook.apply(parseAttributes(sym, denot.info))) |
There was a problem hiding this comment.
With the change, the two applications of cook.apply are in 1-to-1 correspondence with the two calls to parseAttributes. Add the cook.apply to the result type of parseAttributes instead?
Otherwise LGTM
Only the ClassfileParser is fixed (because we can just ask users to fix their Java source files to not use raw types to get them to compile with Dotty). This means that the added Java testcase does not pass Dotty's Java source parser, we handle this by putting "JAVA_ONLY" in the filename and skipping files that contain this string from going through Dotty in our testing framework.
smarter
force-pushed
the
fix-raw-in-generic
branch
from
34e3750 to
d19a792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.